JS pull-requests

[github-actions[bot]]

This is an automatically created issue used to list automatically createdjavascript pull requests every 3 months.

It was created by the .github/workflows/js-prs-issue.yml workflow in the silverstripe/.github repository.

Triage instructions (Silverstripe Ltd CMS Squad)

1. Put on the following labels:
   • type/enhancement
   • impact/low
   • affects/v5
2. Move this issue to the "Ready" column on our internal zenhub board

Update JS pull-requests:

• List of update JS pull-requests - See comment below
• Merge these PRs if there are no merge-conflicts
• If there are merge conflicts in some PRs, then close those PRs and run the steps below in the "Manually creating update JS pull-requests" section below for those relevant modules

Manually creating update JS pull-requests:

1. Ensure you have the default branch checked out for the module you are updating e.g. 5
2. Ensure silverstripe/silverstripe-admin is installed in a sibling directory
3. In the silverstripe-admin directory, ensure the default branch is checked out e.g. 2
4. In the silverstripe-admin directory, run yarn install
5. In the directory of module you're updating JS for, run yarn upgrade
6. Run yarn build in the directory of module you're updating JS for
7. Git commit, push the changes and create a pull-request
8. List the pull-request(s) on this issue
9. Move this issue to the peer review column on the CMS Squad internal zenhub board

Dependabot pull-requests:

• List of dependabot pull-requests
• Most of these should be automatically closed if the "Update JS pull-requests" above are merged
• You can make a judgement call as to whether to merge any easy ones that are left

PRs

• https://github.com/silverstripe/silverstripe-admin/pull/1558
• https://github.com/bringyourownideas/silverstripe-maintenance/pull/205
• https://github.com/symbiote/silverstripe-advancedworkflow/pull/503

[emteknetnz]

Blocked by https://github.com/silverstripe/gha-update-js/issues/20 - once those have been merged re-run the workflow on all repos linked in the rhino link above, then re-run rhino to get the list of the latest PRs

[emteknetnz]

Have re-run github jobs, next rhino run is early Thursdays morning

[emteknetnz]

Have merged all the PRs except for this ones which have red CI builds

• https://github.com/silverstripe/silverstripe-elemental/pull/1087
• https://github.com/silverstripe/silverstripe-admin/pull/1556

[GuySartorelli]

I've created https://github.com/silverstripe/gha-update-js/issues/23 to handle the broken elemental PR.

Reassigning to @emteknetnz to deal with the dependabot PRs which are still sitting there.

[emteknetnz]

Have run @dependabot rebase on all the dependabot PRs which will auto close anything that's no longer required - look at link again to see what's left

[emteknetnz]

The @dependant merge didn't work right on a dependabot PR for ckan-registry. I simply closed it. For a different approach - after all the pull-requests in https://github.com/silverstripe/module-standardiser/issues/17 are merged the update-js workflow will be available on a few more module. For all the repositories in the list of dependabot PRs, just run the the update-js workflow on them. There are a few ckan PRs there so the fact I closed on of them won't matter.

[GuySartorelli]

PRs merged.