search

silverstripe / api.silverstripe.org

API documentation for the Silverstripe Framework
BSD 3-Clause "New" or "Revised" License
3 stars 14 forks source link

DEP Upgrade to PHP 7.4 explicitly #109

Closed GuySartorelli closed 1 year ago

GuySartorelli commented 1 year ago

Fixes this error found in UAT error logs:

Parse error: syntax error, unexpected 'array' (T_ARRAY), expecting function (T_FUNCTION) or const (T_CONST) in /var/www/mysite/releases/b1113f5fcebbb325cdc3a8019f2c6597d58af11e/src/Console/CheckoutCommand.php on line 21

I could just remove the typehint, but it seems better to just upgrade to PHP 7.4 since that's what I was developing on so a) we know it works and b) it's got security fixes that aren't in 7.3

There's a separate card to upgrade to 8.1 in the future, but that's more work so is out of scope right now. This PR is primarily aimed at getting the code from https://github.com/silverstripe/api.silverstripe.org/pull/107 running in ss cloud.

Issue