search

silverstripe / api.silverstripe.org

API documentation for the Silverstripe Framework
BSD 3-Clause "New" or "Revised" License
3 stars 14 forks source link

Link to github in footer #65

Closed chillu closed 3 years ago

chillu commented 6 years ago

We do this on docs as well. Without that link, people don't know where to report bugs, and realise they can actually help fixing them ;)

williamdes commented 3 years ago

Implemented in 5.3.0 :rocket:

williamdes commented 3 years ago

Deployed preview: https://williamdes.github.io/mariadb-mysql-kbs/

LGTM :heavy_check_mark:

chillu commented 3 years ago

@williamdes Awesome, thanks!

Would it be possible to make the footer link specific to the file path and repo that's currently being shown? It'd be a separate issue, just interested in the possibilities. So https://api.silverstripe.org/4/SilverStripe/AssetAdmin/BatchAction/DeleteAssets.html would point to https://github.com/silverstripe/silverstripe-asset-admin/blob/1/code/BatchAction/DeleteAssets.php, but https://api.silverstripe.org/4/SilverStripe/Admin/LeftAndMain.html would point to https://github.com/silverstripe/silverstripe-admin/blob/1/code/LeftAndMain.php

williamdes commented 3 years ago

@williamdes Awesome, thanks!

Would it be possible to make the footer link specific to the file path and repo that's currently being shown? It'd be a separate issue, just interested in the possibilities. So https://api.silverstripe.org/4/SilverStripe/AssetAdmin/BatchAction/DeleteAssets.html would point to https://github.com/silverstripe/silverstripe-asset-admin/blob/1/code/BatchAction/DeleteAssets.php, but https://api.silverstripe.org/4/SilverStripe/Admin/LeftAndMain.html would point to https://github.com/silverstripe/silverstripe-admin/blob/1/code/LeftAndMain.php

Ah, this is the code link feature that is fixed in the other pull-request.

The footer is not to add a link to the source code but to add a link to go to a website or Github repo for the api docs for example

To sum up the feature you ask exists and is not the footer one, it should work after merging the other pull-request ;)