API Rewrite LookupTest, update PHPUnit to 7, add phpcs to Travis, rename Twig file_get_contents

silverstripe / api.silverstripe.org

API documentation for the Silverstripe Framework

BSD 3-Clause "New" or "Revised" License

3 stars 14 forks source link

Closed robbieaverill closed 6 years ago

robbieaverill commented 6 years ago

Replaces the old LookupTest class with something with a couple of new ones in it.

This PR also:

Updates to phpunit 7
Adds phpcs to Travis (with PSR-2 adjustments, incl. renaming the Twig file_get_contents replacement method)

Should we add a full documentation suite build to Travis as well maybe?

robbieaverill commented 6 years ago

Should we add a full documentation suite build to Travis as well maybe?

The exit code is not zero, so we'd have to fix all our phpdoc bugs in core before this would work nicely

NightJar commented 6 years ago

The exit code is not zero, so we'd have to fix all our phpdoc bugs in core before this would work nicely

You could hack it with an inline else for the meantime if it's a feature you'd wanna include. command_that_fails || true

robbieaverill commented 6 years ago

What would be the point in doing that? 😆

NightJar commented 6 years ago

Hmm, got confused with release artifact building (CD) and CI for a sec there, heh.