search

silverstripe / api.silverstripe.org

API documentation for the Silverstripe Framework
BSD 3-Clause "New" or "Revised" License
3 stars 14 forks source link

opensearch broken: configuration points to wrong URL #85

Closed wernerkrauss closed 5 years ago

wernerkrauss commented 5 years ago

I added the "SilverStripe Apidocs" to my search bar in firefox.

Unfortunately it points to sami's default search url https://api.silverstripe.org/4/index.html?q={searchterm} instead of https://api.silverstripe.org/4/search.html?search={searchterm}

same for SS3 search and Master search.

This can be configured in /conf/themes/silverstripe/opensearch.twig

It might also be useful to add a favicon.

robbieaverill commented 5 years ago

Nice catch! Fancy a pull request? The website is open source :-D

maxime-rainville commented 5 years ago

Did a quick fix https://github.com/silverstripe/api.silverstripe.org/pull/86

wernerkrauss commented 5 years ago

When will api docs be rebuilt to include this fix?

robbieaverill commented 5 years ago

I'll deploy this to the UAT site now. I've sent @maxime-rainville a production deployment request to look at on Monday.

maxime-rainville commented 5 years ago

The deploy was completed sucessfully, however I'm still getting the old URL in the opensearch.xml file https://api.silverstripe.org/4/opensearch.xml

Is there a CDN/Cache in front of the site?

robbieaverill commented 5 years ago

CloudFlare probably, can you cache bust to see the new content?

maxime-rainville commented 5 years ago

Don't think I've got access to that.

robbieaverill commented 5 years ago

Oh, looks like the file is generated as part of the docs generation process. Let's give it a day to regenerate itself.

maxime-rainville commented 5 years ago

It's working correctly now.