Demo creation fails if site name does not start with a letter character (incl CWP)

[brynwhyman]

Example error message: (value is \"6xpertscom-sscom\"): only lowercase letters, numbers, underscores and dashes are allowed, must start with a letter"

This is a limitation of the underlying demo creation infrastructure. We see the same problem with the CWP demo: https://github.com/silverstripeltd/cwp-demo/issues/18

It seems that a quick win here would be some validation on the demo request from.

There's a related issue that could also benefit from front-end validation: https://github.com/silverstripe/bambusa-installer/issues/87

AC's

• Where a user attempts to create a demo where the name begins with a non-alpha character, the demo is still successfully created, or the user is given information to change the name.
• This issue exists for the CWP demo as well. The issue should be resolved for CWP as part of this issue too
• Ensure that the team (mostly) responsible for s.com is consulted as part of the deployment required for the Bambusa fix

PR's

• [x] https://github.com/silverstripeltd/silverstripe-demostacker/pull/53 - add better validation
• [x] https://github.com/silverstripeltd/silverstripe.com/pull/186 - use domain_prefix
• [x] https://github.com/silverstripeltd/cwp-demo/pull/31 - use domain_prefix
• [x] https://www.silverstripe.com/silverstripe-cms/demo/ deployed (sscom2)
  • [x] https://github.com/silverstripeltd/silverstripe.com/pull/187/files - fix circleCI on silverstripe.com
  • [x] https://github.com/silverstripeltd/silverstripe.com/pull/188 - update composer demostacker
• [x] https://demo.cwp.govt.nz/ deployed (cwpdemos / ssdemo)
  • [x] https://github.com/silverstripeltd/cwp-demo/pull/32 - update composer demostacker

[maxime-rainville]

We're adding a suffix to the demo name based on what environment the demo is created on. This is meant to avoid collisions between CWP and DotCOM demoes.

A simple fix could be to make it a prefix instead of a suffix.

[brynwhyman]

We've got the same problem with the CWP demo so it seems we should do the same fix for both. I don't believe the CWP demos have a prefix.

If we fix this with form validation, we could probably squeeze the following in as well: https://github.com/silverstripe/bambusa-installer/issues/87

[bergice]

Added new PR's to update sites with merged demostacker changes and to fix circleCI builds on silverstripe.com.

[brynwhyman]

Blocked by: https://silverstripe.freshdesk.com/a/tickets/67189

The latest suggestion is to do a re-deploy of the base stack holding the ss.com vstack. This could result in a PHP upgrade for other projects, so we'll need to make sure that has no adverse affects. I can have a look at this and track someone down to help approve that.

[brynwhyman]

We've received approval from Olivia to proceed with a base stack deployment: https://silverstripeltd.slack.com/archives/C0XL54DEH/p1598910385007000?thread_ts=1598910107.006700&cid=C0XL54DEH