silverstripe / bambusa-installer

SilverStripe demo application
https://silverstripe.com/demo
BSD 3-Clause "New" or "Revised" License
11 stars 8 forks source link

PHP memory limit too low, breaks on image upload #85

Closed chillu closed 5 years ago

chillu commented 5 years ago

https://app.raygun.com/crashreporting/1po60pm/errors/3886025152?dateFrom=2019-09-25T02%3A12%3A00.000Z&dateTo=2019-10-02T01%3A12%3A44.000Z

Looks like there's only 128MB of memory_limit, which seems to crash on larger image resizes. We try to predict when GD would run out of memory in core, but the logic seems to fail here. Of course, we shouldn't resize images in process on the web worker, but that's a different story.

dnsl48 commented 5 years ago

I've increased the memory limit up to 256M (for the following demos). I think that's reasonable enough. Otherwise, I guess we should come up with an external queue based resizing that could be done outside of the application server (lambdas or 3rd party services). I don't see any other sensible options how we could deal with that issue at this point.

chillu commented 5 years ago

Awesome, thanks!