silverstripe / cow

Release tool for Silverstripe CMS
BSD 3-Clause "New" or "Revised" License
6 stars 8 forks source link

Improve changelog readability #186

Closed dnsl48 closed 3 years ago

dnsl48 commented 4 years ago

Overview

The current changelog format is less than optimal. Here's an example: CWP 2.6.0 Release.

Although "security", "features" and "bugfixes" sections are manageable to read, it's still not clear what is going on there, without looking into the linked commits. E.g.:

The message explains the change well, but without the module context it is baffling (RealMe). When it comes to "Other changes" section, there's too much going on and it is hard to find any valuable info by glancing at it.

Proposal

Notes

PRs

Follow up TODO

dnsl48 commented 4 years ago

/cc @silverstripe/core-team

brynwhyman commented 4 years ago

Not that we're necessarily limited to what can be done here, but of the suggested points in the proposal my thoughts are this is the most important as there's a lot of clutter there:

Add new commit prefixes for Continuous Integration related commits (RFC tbc)

Plus, as discussed an additional heading for the DOCS prefix would be nice.

Aside from that, I really like the idea of #184 and would prioritise that over making the CWP changelog more readable. Given the CWP changelog includes the entire kitchen-sink, I don't feel like it's an optimal list to refer Developers to? Where possible, the module repository could be referred to as the source of truth

Perhaps we could discuss with CWP Developers the usefulness of using the CWP changelog page to include commits for cwp/cwp-recipe-core and cwp/cwp-recipe-cms and otherwise list the new module versions and GitHub changelog links (assuming #184) contained in the release?

dnsl48 commented 4 years ago

Given the CWP changelog includes the entire kitchen-sink, I don't feel like it's an optimal list to refer Developers to?

One source of truth for all the modules is very important nonetheless. It's just impossible for devs to check out 100 different places to see every module own changelog when a release is out.

brynwhyman commented 4 years ago

Fair point 😄

robbieaverill commented 3 years ago

I think this issue highlights the importance of writing succinct and descriptive commit messages

Cheddam commented 3 years ago

Whoops, this shouldn't be closed until all three PRs are merged!