FIX Update oembed config

silverstripe / cwp-core

CWP basic compatibility module

BSD 3-Clause "New" or "Revised" License

3 stars 12 forks source link

FIX Update oembed config #107

Closed emteknetnz closed 2 years ago

emteknetnz commented 2 years ago

Issue https://github.com/silverstripe/silverstripe-framework/issues/10305

Requires https://github.com/silverstripe/silverstripe-framework/pull/10312 to allow multiple backtick values to be set at once

Requires https://github.com/silverstripe/silverstripe-framework/pull/10311 so that guzzle is being used

Release ~~2.10.1~~ 2.11.0-beta1 when merged

GuySartorelli commented 2 years ago

The fact that this is passing in travis when its dependencies aren't merged in yet seems a bit concerning... is there some tests that should be added to test this?

emteknetnz commented 2 years ago

It's hard to test since what the purpose of this is to work on CWP hosting where there are some environment variable set.

I've added a unit test to test that framework is configured to create a Guzzle client, so in case we change the client again in the future so the config makes no sense, it should break.

Note: unit test needs https://github.com/silverstripe/silverstripe-framework/pull/10311 merged first

Update: have tested this works CWP hosting in conjuction with the 2x framework PRs