FIX Remove attempt to import environment into config for docvert

silverstripe / cwp-core

CWP basic compatibility module

BSD 3-Clause "New" or "Revised" License

3 stars 12 forks source link

FIX Remove attempt to import environment into config for docvert #33

Closed NightJar closed 6 years ago

NightJar commented 6 years ago

Currently this default is non-functional, and e.g. the URL gets set to

`DOCVERT_URL`

which clearly is not a URL, nor even a valid domain. As this docvert prioritises config over environment, this makes a mess of any attempts to import data by making the docvert server unreachable.

robbieaverill commented 6 years ago

Please wait until https://github.com/silverstripe/silverstripe-framework/issues/7987 has been responded to. As far as I know this should be supported in the framework, so I don't think we should be removing it.

NightJar commented 6 years ago

There are no unit tests in core that I could find to cover such functionality. But that's cool, we can wait to merge. There's no particular rush until release time.