search

silverstripe / cwp-core

CWP basic compatibility module
BSD 3-Clause "New" or "Revised" License
3 stars 12 forks source link

Rename SolrSearchIndex to CwpSolrIndex #4

Closed robbieaverill closed 6 years ago

robbieaverill commented 6 years ago

Migrated from GitLab

cc @chillu

See commit message and https://gitlab.cwp.govt.nz/cwp/cwp/merge_requests/65. It's technically an API change, I'm not sure how we handle semver with CWP. Until recently, defining a new index would work in parallel to the built-in CWP index, so its likely that even early adopters of custom indexes won't need to change anything in their custom code.

Comments

Usernames adjusted for GitHub

Damian Mooyman @tractorcow commented 2 years ago

Do you still need this? It'll need a rebase.

Robbie Averill @robbieaverill commented about a minute ago

I found this very confusing when getting into Solr. +1 for the change. I'll move this to GitHub as an issue and we can attack it for SS4 version.

tractorcow commented 6 years ago

This change must be done in a new major version, so pretty much cwp 2.0.0 or 3.0.0.

robbieaverill commented 6 years ago

I'm going to make a PR for this change shortly

robbieaverill commented 6 years ago

Ok pull request ready to go once #6 is merged in

tractorcow commented 6 years ago

Not actually done in https://github.com/silverstripe/cwp-core/pull/6 so re-opening.

robbieaverill commented 6 years ago

It was done in #8, not #6

tractorcow commented 6 years ago

Doh, you're right.

Have the cwp 2.0 docs been updated with this change?

robbieaverill commented 6 years ago

Nah they haven't, but I think we'll need a full task to review all of the docs anyway. I'll make sure we update the cwp/cwp docs in master as we go from now on though

tractorcow commented 6 years ago

See https://github.com/silverstripe/cwp/blob/master/docs/en/02_Features/01_Solr_search/04_Default_search_index.md

robbieaverill commented 6 years ago

PR coming shortly

robbieaverill commented 6 years ago

Ok, pull request at https://github.com/silverstripe/cwp/pull/11