search

silverstripe / cwp-core

CWP basic compatibility module
BSD 3-Clause "New" or "Revised" License
3 stars 12 forks source link

Update textextraction config #82

Closed emteknetnz closed 4 years ago

emteknetnz commented 4 years ago

This is a cherry-pick of previous commit to 2 that went into 2.3 though not 2.2 https://github.com/silverstripe/cwp-core/commit/192dcaebdc07351fa5ce198ab9449e861171367d

It's to fix this test in cwp-recipe-kitchen-sink https://travis-ci.org/silverstripe/cwp-recipe-kitchen-sink/jobs/625881938

Basically what was happening is that an extra version of a File was being written though not published, so a logged out $file->canView() check was failing because the draft version was 3 while the live version was 2

robbieaverill commented 4 years ago

You can add dist: trusty to .travis.yml to get the builds passing. I don't have contributor access to your fork in this PR for some reason, so can't add it myself. The config change here is not backwards compatible, but given that it was wrong to start with I don't see it as an issue.