search

silverstripe / cwp-installer

CWP project template
BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

Remove subsites module as default functionality #33

Closed brynwhyman closed 4 years ago

brynwhyman commented 4 years ago

Overview

For new sites, where the development agency wants to use this package to kickstart their project, we shouldn't assume that the subsites module should be provided by default.

Given that subsites significantly impacts how the site can be maintained in the future, it is a decision that should be supported by conversations between the development agency and site owner and good documentation, e.g CWP website (WIP) and the module readme where a number of limitations are noted.

This issue tracks removing the subsite module from the CWP installer for the next minor version.

Pull request

Note, this is all I could see requiring a change so I've created the PR. I'd appreciate input in case other areas may need updating.

michalkleiner commented 4 years ago

👏

Next one — taxonomy module.

brynwhyman commented 4 years ago

😆 Great to see some support @michalkleiner. Yup, fair call on the taxonomy module. What's your reasoning for removing this functionality from the base installer?

michalkleiner commented 4 years ago

Our reason is that we have a custom taxonomies module and we need to be hiding the SS module's model admin and the tag field from everywhere to avoid CMS user's confusion. The taxonomy module can still come in as a dependency of recipe-blog or added by agencies per project when required.

brynwhyman commented 4 years ago

Note that there is a follow-up issue for docs updates here: https://github.com/silverstripe/cwp/issues/272. That shouldn't block this issue and will happen before the next minor release.