search

silverstripe / cwp-installer

CWP project template
BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

Enable projects to use a public webroot by default #6

Closed robbieaverill closed 6 years ago

robbieaverill commented 6 years ago

Since CWP 2.0 will ship with SS core 4.1.x we will have the ability to implement a public webroot as the base for serving web requests:

We'll also need to add documentation to cwp/cwp to ensure that if users want to disable this they know how to.

NightJar commented 6 years ago

This recipe is already based from 4.1.x (via dev requirements to various other recipes), so I should imagine this issue to be more of a test to ensure functionality remains :)

robbieaverill commented 6 years ago

I don't think the public webroot feature is enabled by default, so this ticket is to enable it for CWP 2.0

NightJar commented 6 years ago

Seems to be, as I just installed the 4.1 dev branch via silverstripe/installer (in that it requires silverstripe/recipe-cms:1.1.x-dev same as here in #5 ) and it's running out of public. That of course doesn't preclude something in silverstripe/installer specifically that is enabling this, so it's worth testing still :)

robbieaverill commented 6 years ago

Whoops - closed by accident

NightJar commented 6 years ago

Does the existing public/ folder in this recipe not achieve the desired effect? I will test.

NightJar commented 6 years ago

Tested, works :) (as is, current master)

~/work/cwp2test (master)
$ ls
behat.yml  composer.json  composer.lock  gridfield-bulk-editing-tools/  mysite/  phpcs.xml.dist  phpunit.xml.dist  public/  README.md  robots.txt  themes/  vendor/

~/work/cwp2test (master)
$ ls public/
index.php  install.php  install-frameworkmissing.html  resources/  web.config

Thanks @tractorcow for the guidance.

tractorcow commented 6 years ago

Yep all good. Unlike other recipe files, the public folder needs to be in every recipe down the stack.