search

silverstripe / cwp-recipe-basic

CWP 1.x Basic Recipe metapackage (no longer used in CWP 2.x)
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Hide deprecated warnings #10

Closed emteknetnz closed 3 years ago

emteknetnz commented 3 years ago

Issue https://github.com/silverstripeltd/product-issues/issues/437

Note: cms3 travis failures are expected

emteknetnz commented 3 years ago

It feels like moving it to the php file is going to cause future problems if it gets retired.

I think the chance of _ss_environment.php getting retired from CMS 3 projects it's pretty low :-)

What is the advantage of moving the error reporting from an ini file to the _ss_enviornment.php

Possibly none other then we don't need to spend any time getting it to work with via ini. Silverstripe sets some error_reporting() of its own so there may be a conflect. I don't think it really matters how we set it in the context of a travis build

michalkleiner commented 3 years ago

Since the config was E_ALL & ~E_DEPRECATED already and this change just moves it around, in the context of the issue title, is it even needed? Does updating the dist that travis runs make any difference to that?

emteknetnz commented 3 years ago

Config wasn't working for some reason and travis was spamming deprecated warnings so I changed around how it was set and it resolved

Does updating the dist that travis runs make any difference to that?

Probably not, though bionic is what we run on the travis shared config

emteknetnz commented 3 years ago

That's a pre-existing failure present on the PHP 7.3 build

We're specifically not fixing pre-existing failures as part of this issue, we're simply checking that php7.3 and php7.4 behave the same - see the first AC on https://github.com/silverstripeltd/product-issues/issues/437

emteknetnz commented 3 years ago

@maxime-rainville have removed comment