silverstripe / cwp-recipe-basic

CWP 1.x Basic Recipe metapackage (no longer used in CWP 2.x)
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Includes fulltextsearch without also including cwp-recipe-search #2

Closed chillu closed 5 years ago

chillu commented 6 years ago

See https://github.com/silverstripe/cwp-recipe-basic/blob/master/composer.json. So you get the module without the support code required for CWP.

The installer includes cwp/cwp-recipe-search, which sets up the module properly: https://github.com/silverstripe/cwp-installer/blob/master/composer.json

Aside: Where is cwp-recipe-basic included anyway? I can't see it in cwp-recipe-core or the installer.

robbieaverill commented 6 years ago

So cwp-recipe-basic is a CWP 1.x only recipe. In CWP 2.x we're using the search recipe which includes the required search modules and code, but you don't have to install it

robbieaverill commented 5 years ago

I think this is a misunderstanding, but feel free to reopen if not

chillu commented 5 years ago

Ah right, sorry for not responding!