search

silverstripe / cwp-recipe-kitchen-sink

The CWP kitchen sink! Includes all optional and suggested modules. Used for internal testing.
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

2.2/2.x: Test failures #13

Closed robbieaverill closed 6 years ago

robbieaverill commented 6 years ago

We have two test failures at the moment:

The first one should be fixable. The test in question wasn't even running in 2.1 until it was re-enabled.

The second one is a functional regression logged as https://github.com/silverstripe/silverstripe-securityreport/issues/38

robbieaverill commented 6 years ago

Subsites has been reverted.

https://github.com/silverstripe/silverstripe-admin/commit/249e33a56d53b68392b6dc2d3b4d93179dec3387 caused the LeftAndMain test to fail. It previously wasn't actually asserting anything. I'll rewrite it.

robbieaverill commented 6 years ago

PR for LeftAndMain https://github.com/silverstripe/silverstripe-admin/pull/704/files

dhensby commented 6 years ago

Are we done here?

robbieaverill commented 6 years ago

Yep, we have another issue to fix the rest