search

silverstripe / cwp-recipe-kitchen-sink

The CWP kitchen sink! Includes all optional and suggested modules. Used for internal testing.
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

Fix 2.2 failing builds #27

Closed brynwhyman closed 5 years ago

brynwhyman commented 5 years ago

Failed on 27/02/19

https://travis-ci.org/silverstripe/cwp-recipe-kitchen-sink/builds/498724570


1) SilverStripe\CronTask\Tests\CronTaskControllerTest::testDefaultQuietFlagOutput
Failed asserting that '2019-47-26 13:: - CWP\PDFExport\Tasks\CleanupGeneratedPdfDailyTask will run at 2019-02-27 00:00:00.
2019-47-26 13:: - SilverStripe\CronTask\Tests\CronTaskTest\TestCron will run at 2019-02-26 14:00:00.
' matches PCRE pattern "#2019-46-26#".
/home/travis/build/silverstripe/cwp-recipe-kitchen-sink/vendor/phpunit/phpunit/phpunit:52
robbieaverill commented 5 years ago

Looks like a legit bug, maybe we are doing bad date formatting

robbieaverill commented 5 years ago

Yeah this our date format in a unit test: DBDatetime::now()->Format('Y-m-d') - that's wrong, will update shortly

robbieaverill commented 5 years ago

PR at https://github.com/silverstripe/silverstripe-crontask/pull/51

robbieaverill commented 5 years ago

Merged and restarted the builds - I'll reopen if that didn't fix it