search

silverstripe / cwp-recipe-kitchen-sink

The CWP kitchen sink! Includes all optional and suggested modules. Used for internal testing.
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

Fresh install Page/PageController extends SiteTree/ContentController instead of CWP BasePage #30

Closed robbieaverill closed 5 years ago

robbieaverill commented 5 years ago

This affects the kitchen sink but not cwp-installer.

I think it's related to https://github.com/silverstripe/recipe-plugin/issues/12

The Page and PageController you get with a fresh project come from silverstripe/recipe-cms instead of cwp/cwp-recipe-cms, so extend SiteTree and ContentController instead of BasePage and BasePageController.

It means you need to modify this manually before doing any kitchen sink recipe testing.

robbieaverill commented 5 years ago

Closing - if https://github.com/silverstripe/recipe-plugin/issues/12 is eventually resolved then we can add configuration to fix it here, but given that the kitchen sink is just for us, I think we'll mark this as a known issue and #wontfix.

robbieaverill commented 5 years ago

I've noted this in the readme to help in future: https://github.com/silverstripe/cwp-recipe-kitchen-sink/commit/6715ed281908d5867a9ba648d5f0192c930ae9fe