search

silverstripe / cwp-recipe-kitchen-sink

The CWP kitchen sink! Includes all optional and suggested modules. Used for internal testing.
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

Inline PHP 7.1 dependencies in Travis config to retain PHP 5.6 config #33

Closed robbieaverill closed 5 years ago

robbieaverill commented 5 years ago

https://travis-ci.org/silverstripe/cwp-recipe-kitchen-sink/builds/519642327?utm_source=slack&utm_medium=notification has started failing since we made silverstripe/mfa require PHP 7.1.

In order to retain PHP 5.6 builds, we can remove the dependency from kitchen sink and inline it in travis.yml installation steps instead for PHP 7.1 only.

Relevant (private) Slack thread: https://silverstripeltd.slack.com/archives/C4GE7BHN3/p1555162588003200

robbieaverill commented 5 years ago

Picking this up since it's a good time to be running kitchen sink builds for me without interrupting NZ workflow by creating a large Travis backlog time

robbieaverill commented 5 years ago

PR at https://github.com/silverstripe/cwp-recipe-kitchen-sink/pull/41, I'll adjust and self-merge any trivial test fixes to ensure it's green, then will self-merge the PR and merge up so it's all set as a default in CWP 2.4

robbieaverill commented 5 years ago

Example failure (due to CWP password strength rules): https://travis-ci.org/creative-commoners/cwp-recipe-kitchen-sink/jobs/562029118#L1023

robbieaverill commented 5 years ago

There was only one failure due to global state changes in the password validator strength rules. I've adjusted that and merged my PR into the kitchen sink, and merged it up to master. I've also removed PHP 7.2 from CWP 2.4/master since we don't support it yet (there's other issues for that logged), so the test failures in 2.4 and master should represent valid issues now.