Fix queuedjob-security extension tests

silverstripe / cwp-recipe-kitchen-sink

The CWP kitchen sink! Includes all optional and suggested modules. Used for internal testing.

BSD 3-Clause "New" or "Revised" License

1 stars 5 forks source link

Fix queuedjob-security extension tests #48

Closed dnsl48 closed 4 years ago

dnsl48 commented 4 years ago

A TravisCI test is failing because some of queuedjobs tests create HTTPRequest without initializing Injector with it. Later, security-extensions try to access the request through injector and fail. Need to come up with a solution for that (since that's integration issue and not an issue of each one of those on their own).

PRs

[x] https://github.com/silverstripe/cwp-recipe-kitchen-sink/issues/48

emteknetnz commented 4 years ago

This is now passing https://travis-ci.org/silverstripe/cwp-recipe-kitchen-sink/branches - we can close this issue?

dnsl48 commented 4 years ago

yes, the PR link is incorrect, but I remember reviewing the patch myself :) closing