search

silverstripe / cwp-recipe-kitchen-sink

The CWP kitchen sink! Includes all optional and suggested modules. Used for internal testing.
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

Broken travis build for 2.2 #50

Closed emteknetnz closed 4 years ago

emteknetnz commented 4 years ago

https://travis-ci.org/silverstripe/cwp-recipe-kitchen-sink/builds/625881936

The first failure is silverstripe/assets FileTest.php testCanViewInheritsRecursively()

Unit tests pass for assets module if run on the assets module itself

Seems to be a complication when running with the versioned module, specifically canViewVersioned() which is called by canView() within the failing unit test

Have tried upgrading both silverstripe/assets and silverstripe/versioned to the 1.4.x-dev and 1.5.x-dev respectively to match kitchen-sink 2.3, however the test still fails. The same test passes in 2.3

emteknetnz commented 4 years ago

PR: https://github.com/silverstripe/cwp-core/pull/82

emteknetnz commented 4 years ago

^ Above PR is green and ready for merge

emteknetnz commented 4 years ago

PR for 2.3 to get memory to 3G and ensure that future merge ups work correct https://github.com/silverstripe/cwp-recipe-kitchen-sink/pull/53

maxime-rainville commented 4 years ago

All PRs have been merged. The PR build was green, so the branch build should be green as well ... if it isn't, it's probably going to be a different problem any way.