Cannot open /dev/tasks in browser on CWP or SSP

silverstripe / cwp

Common Web Platform (CWP) features module. We strongly recommend using it for all new CWP projects. Future features will be delivered here.

https://www.cwp.govt.nz

BSD 3-Clause "New" or "Revised" License

10 stars 26 forks source link

Cannot open /dev/tasks in browser on CWP or SSP #124

Closed robbieaverill closed 6 years ago

robbieaverill commented 6 years ago

CWP 2.1.0-beta1

When a kitchen sink recipe is deployed to either CWP or SSP platform, the /dev/tasks URL cannot be used.

Expected: see list of tasks

Actual:

500 error (platform)
503 error (CWP)
Server error page is displayed
Server error page contains the simple theme markup. The simple theme is not in this project

While there are entries in Graylog for these requests, they provide no useful information other than the HTTP status code.

robbieaverill commented 6 years ago

So far what I've tried with @jakedaleweb:

Clear the static error 404 and 500 pages from the assets folder, so that dev/build will regenerate them (trying to remove simple theme references)
Set environment type to dev (from test) manually on the servers
Check Graylog for errors

We also noticed two other things:

Audit entries regularly for Member records being modified, possibly because of a last logged in date being set?
/dev/tasks may redirect to /Security/login and back again in an infinite loop - we've seen this end in a 429 rate limiting HTTP response

I can't reproduce this locally with dev or test environment types, so we might need to collaborate with TSP to debug why this is happening.

jakedaleweb commented 6 years ago

Have seen similar issues in ss4 sites where there are silent errors. Previously this was caused by use of SS_Log (deprecated) to log the error or incorrect name-spacing on Exception.

Have confirmed that dev/tasks is accesible via CLI i.e. framework/sake dev/tasks

robbieaverill commented 6 years ago

Have seen similar issues in ss4 sites where there are silent errors

Yeah - one problem is when /dev/build (for example) redirects somewhere, the exit code from vendor/bin/sake dev/build is zero which indicates success, yet nothing was done. It looks like the platform scripts check for empty output from these commands to determine failure though.

robbieaverill commented 6 years ago

cURL response:

$ curl -I https://myusername:opensesame@training-uat.cwp.govt.nz/dev/tasks
HTTP/2 503 
server: nginx
date: Mon, 25 Jun 2018 23:23:21 GMT
content-type: text/html
content-length: 0
etag: "5b307030-0"
set-cookie: visid_incap_160125=UxiFd1XwTXG35mprqRHKpWh5MVsAAAAAQUIPAAAAAAD1NibAYUZrpwvEr5eOynO0; expires=Tue, 25 Jun 2019 09:36:16 GMT; path=/; Domain=.cwp.govt.nz
set-cookie: incap_ses_248_160125=hpNHLdI5xUgcZ9Yb1RRxA2l5MVsAAAAA09shLGsazoMCg5Uihdf4xg==; path=/; Domain=.cwp.govt.nz
x-iinfo: 5-8741419-8741420 NNNN CT(10 26 0) RT(1529969000423 0) q(0 0 0 0) r(6 6) U6
x-cdn: Incapsula

robbieaverill commented 6 years ago

Following up from https://github.com/bringyourownideas/silverstripe-maintenance/issues/113, this is fixed. In this module there is a build task that has a dependency (via Injector) which is throwing a RuntimeException during construction - this is not being handled by SilverStripe's error handler, so was returning a 503 with no useful information at all to debug it.

@NightJar I think we should log an issue for this on framework so it can be fixed

robbieaverill commented 6 years ago

Fixed via https://github.com/bringyourownideas/silverstripe-maintenance/issues/113