search

silverstripe / cwp

Common Web Platform (CWP) features module. We strongly recommend using it for all new CWP projects. Future features will be delivered here.
https://www.cwp.govt.nz
BSD 3-Clause "New" or "Revised" License
10 stars 26 forks source link

Incorrect PHP settings recommended for Increasing Session timeout. #157

Closed brettt89 closed 6 years ago

brettt89 commented 6 years ago

Hi Team,

While working through increasing a Session maxlifetime with a client, I found the CWP documentation to be incorrectly documented.

https://www.cwp.govt.nz/developer-docs/en/2/working_with_projects/security/#user-session-expiration-2

It mentions changing a value in php.ini ("session.gc_lifetime") however this value is incorrect, it should be "session.gc_maxlifetime". Also the link that is provided is linked to the wrong anchor. It should be: "http://www.php.net/manual/en/session.configuration.php#ini.session.gc-maxlifetime"

ScopeyNZ commented 6 years ago

Thanks for the report. Can you run over this PR and see if that addresses the issues?

https://github.com/silverstripe/cwp/pull/158

brettt89 commented 6 years ago

👍 Approved