search

silverstripe / cwp

Common Web Platform (CWP) features module. We strongly recommend using it for all new CWP projects. Future features will be delivered here.
https://www.cwp.govt.nz
BSD 3-Clause "New" or "Revised" License
10 stars 26 forks source link

DOCS Update starter and Watea documentation for Bootstrap 4 and theme colour mixin usage #192

Closed robbieaverill closed 5 years ago

robbieaverill commented 5 years ago

Issue: https://github.com/silverstripeltd/cc-issues/issues/298

michalkleiner commented 5 years ago

Is yarn the preferred way for everything CWP/SS rather than npm or npx?

Cheddam commented 5 years ago

@michalkleiner Yes - Yarn has been adopted across the full SilverStripe / CWP core at this point (along with Node 10.x from SilverStripe 4.4 onwards).

michalkleiner commented 5 years ago

Thanks @Cheddam. Is there any reasoning for this other than it was cool for a bit of time when npm didn't have lock files? Something along the lines why SS chose to use React for the CMS against Angular (or whichever other JS fw was the other contender)?

robbieaverill commented 5 years ago

@michalkleiner I think that one of our jobs is to choose appropriate tools for the job, implement them consistently, and promote them to other SilverStripe developers and users. Yarn would've been chosen at the time because it had locking which npm didn't (at the time), and we continue to adopt it across our supported module suite and promote its use.

In the case of this pull request - you're obviously welcome to use whatever build tooling you want when working on CWP projects. These docs are to suggest recommended approaches for people to get started with the themes, and using the same toolchain as the rest of SilverStripe is a good way to minimise confusion on that front.

michalkleiner commented 5 years ago

@robbieaverill I'm not questioning that and certainly didn't want to come across "in attack mode", I was just curious if the only reason was the lock file or there was something else. Agree that the discussion is out of the scope of this PR. Cheers