silverstripe / cwp

Common Web Platform (CWP) features module. We strongly recommend using it for all new CWP projects. Future features will be delivered here.
https://www.cwp.govt.nz
BSD 3-Clause "New" or "Revised" License
10 stars 26 forks source link

TinyCME config generated after each member login #208

Open sig-critchie opened 5 years ago

sig-critchie commented 5 years ago

Affected Version

cwp 2.2.3

Description

TInyMCE config is generated after each login, this seems to be due to "spellchecker_rpc_url" having a different "SecurityID" param, per user per session.

SilverStripe\Forms\HTMLEditor\TinyMCECombinedGenerator::generateFilename()

determines if the config needs to generated by hashing the output of

SilverStripe\Forms\HTMLEditor\TinyMCEConfig::getAttributes()

as the config is different each time, "assets/_tinymce" is being filled up with config files.

Expected Behavior

TInyMCE config is generated once.

Actual behavior

TinyMCE config is generated after each login.

Steps to Reproduce

  1. Logout of the CMS
  2. Login to the CMS
  3. Browse to a page with an HTMLEditorField
robbieaverill commented 5 years ago

Thanks for the report. The impact of this is that users need to download the TinyMCE configuration files more often than they should?