silverstripe / cwp

Common Web Platform (CWP) features module. We strongly recommend using it for all new CWP projects. Future features will be delivered here.
https://www.cwp.govt.nz
BSD 3-Clause "New" or "Revised" License
10 stars 26 forks source link

FulltextSearch as an optional dependency should not be referenced directly #21

Closed NightJar closed 6 years ago

NightJar commented 6 years ago

Fulltext functionality is intended to be optional to the site's requirements, however is currently set as the default in all search related activities (c.f. CWP\CWP\PageTypes\BasePageController.search_index_class config setting) settings an out of the box dependency on what is unlisted as a requirement, and should be optional.

This cwp module is intended to provide base plate type functionality that makes it easy to utilise e.g. a SearchForm, however it isn't necessarily used, nor if it is that it should be required to have an advanced Solr type setup (which the default provider subclasses). silverstripe/fulltextsearch is extended (subclassed) directly in various places, however is not currently required (nor do I think should be) by this module, nor any of it's dependencies.

This issue is of two parts, one to separate out what is contained in this cwp repository, and the other to affect the cwp-core repository: https://github.com/silverstripe/cwp-core/issues/14

Ideally there'll be e.g. cwp/cwp-search or suchlike that would house the adaptive functionality that enables the features provided by/for the platform, rather than essentially having an unlisted dependency for this module.

Pull requests

robbieaverill commented 6 years ago

I'm going to do this on top of the changes in https://github.com/silverstripe/cwp/pull/25 to avoid conflicts

robbieaverill commented 6 years ago

Repo created at https://github.com/silverstripe/cwp-search

robbieaverill commented 6 years ago

Pull requests added to the description