silverstripe / cwp

Common Web Platform (CWP) features module. We strongly recommend using it for all new CWP projects. Future features will be delivered here.
https://www.cwp.govt.nz
BSD 3-Clause "New" or "Revised" License
10 stars 26 forks source link

only run tinyMCE code when you need to #210

Closed sunnysideup closed 5 years ago

sunnysideup commented 5 years ago

I am wondering why this code:

https://github.com/silverstripe/cwp/blob/1f7ba0c0ee566329e981cdbf1609f3c94da4aa44/_config.php

Is in the global space. Why not run that whenever an HTML editor is created?

In the past, we have also hacked this to say that if the request url starts with /admin/, we run it.

robbieaverill commented 5 years ago

Closing as a duplicate of https://github.com/silverstripe/cwp/issues/139 =)

sunnysideup commented 5 years ago

;-)))) sorry! I did feel a little deja vu... ;-)