search

silverstripe / cwp

Common Web Platform (CWP) features module. We strongly recommend using it for all new CWP projects. Future features will be delivered here.
https://www.cwp.govt.nz
BSD 3-Clause "New" or "Revised" License
10 stars 27 forks source link

FIX: WR325373 guard for invalid dates on datedupdatecontroller #243

Closed elliot-sawyer closed 4 years ago

elliot-sawyer commented 4 years ago

Fixes issue #242

elliot-sawyer commented 4 years ago

The value for both variables ends up getting passed to strtotime. further down the call stack. If the format is incorrect the user might get unexpected results, but it isn't unsafe. Depending on the value may be the cause of Filter has been applied with the dates reversed

elliot-sawyer commented 4 years ago

@maxime-rainville I'll add some tests on Monday

elliot-sawyer commented 4 years ago

@maxime-rainville I've added your test