search

silverstripe / cwp

Common Web Platform (CWP) features module. We strongly recommend using it for all new CWP projects. Future features will be delivered here.
https://www.cwp.govt.nz
BSD 3-Clause "New" or "Revised" License
10 stars 26 forks source link

FIX Don't throw exception for bad dates with mysql 8.0 #312

Closed GuySartorelli closed 2 years ago

GuySartorelli commented 2 years ago

Follow-up from #310 Fixes https://github.com/silverstripe/recipe-solr-search/runs/7352246945?check_suite_focus=true

Bit of an odd fix as it does add API, but I think that's unavoidable in this situation.

Parent issue

GuySartorelli commented 2 years ago

feels like we're hacking in some ugly code just to fix a unit test

It's not just the test though. The test is correctly failing, because the functionality is broken. This PR aims to fix the broken functionality.

emteknetnz commented 2 years ago

Closing in favor of https://github.com/silverstripe/cwp/pull/311