silverstripe / cwp

Common Web Platform (CWP) features module. We strongly recommend using it for all new CWP projects. Future features will be delivered here.
https://www.cwp.govt.nz
BSD 3-Clause "New" or "Revised" License
10 stars 26 forks source link

CMS 5 - Installed modules report - CWP filter doesn't work #320

Closed emteknetnz closed 1 year ago

emteknetnz commented 1 year ago

Discovered as part of 5.0.0 beta testing

Filtering on CWP recipe modules - I see no results

Non-CWP works, though shows everything including 'cwp' module

Installed modules report uses bringyourownideas/silverstripe-maintainence SiteSummary report

cwp updates it with CwpSiteSummaryExtension

Acceptance criteria

PRs

Follow up card

GuySartorelli commented 1 year ago

I think at this stage the fix for this is to remove that feature. CWP isn't its own thing anymore.

maxime-rainville commented 1 year ago

Even if we don't end up supporting this officially in CMS5, I would like to have the module in a good state initially.

I'm flexible on how we get there. This could mean we take out the filter altogether.

michalkleiner commented 1 year ago

We always got people raising tickets around CWP reports just because they were there and the clients tested all they could find in the CMS despite not actually requiring these functions/reports, so I'd be also ok with removing that for CMS5.

emteknetnz commented 1 year ago

CWP will override the default supported/unsupported modules with a cwp/non-cwp filter

I've deleted the extension so the supported/unsupported module filter shows again, and I've updated it to use the official supported modules json

The filter now seems far more useful

GuySartorelli commented 1 year ago

PRs merged