search

silverstripe / developer-docs

Developer documentation for Silverstripe CMS
Other
6 stars 67 forks source link

Document release branch creation process #21

Closed chillu closed 2 years ago

chillu commented 5 years ago

The Making a core release docs don't spell out how to handle new minor release branches (e.g. branching off 4 to 4.4), and how that affects branch aliases in recipes/installer, as well as the dependencies in those.

Option A: Set recipes/installer constraints on major release branch (e.g. 4) to the branch-alias. Example: silverstripe/installer:4.x-dev requires silverstripe/recipe-cms:4.5.x-dev

Option B: Set recipes/installer constraints on major release branch (e.g. 4) to the major release branch of the dependency. Example: silverstripe/installer:4.x-dev requires silverstripe/recipe-cms:4.x-dev

We're effectively doing Option A everywhere already, but there's been some confusion between @robbieaverill @ScopeyNZ and myself around this (see https://github.com/silverstripe/silverstripe-installer/commit/cfba4cbe3602c666bd3481b9786b5b9bd5932336 and https://github.com/silverstripe/silverstripe-installer/commit/3e7294ea705096d9a3200ba6f46963b1d0884f88).

I'm proposing that we're keeping Option A, but documenting this better.

The CWP release instructions on https://silverstripe.atlassian.net/wiki/spaces/CWP/pages/655458662/Instructions+for+CWP+release already reflect this (see point 3.1)

GuySartorelli commented 2 years ago

This will be handled as part of https://github.com/silverstripe/developer-docs/issues/49