silverstripe / developer-docs

Developer documentation for Silverstripe CMS
Other
6 stars 57 forks source link

DOC Update syntax for callout blocks #452

Closed GuySartorelli closed 5 months ago

GuySartorelli commented 5 months ago

IMPORTANT

This should not be merged until all of the associated PRs have all been approved. Only merge when all of the PRs are ready to go, to minimise the amount of time spent with broken callout blocks.

Description

Converts all of the legacy callout blocks to the new syntax. Note that we're not doing CMS 3.

There is a separate PR for CMS 4. Lots of the changes will be the same, but there's been enough change between majors that a direct merge up will be a pain in the butt, so I've done two separate PRs. Once they're both merged the merge-up process will literally be to throw away the differences and keep the CMS 5 copy.

Note that most of the callout blocks will be converted as per https://github.com/silverstripe/doc.silverstripe.org/issues/282#issuecomment-1915939874 - but there are some which were intentionally changed. I will note those with comments. If I haven't added a comment on something that has been converted differently than that table suggests, assume I messed up.

Issues

Pull request checklist

GuySartorelli commented 5 months ago

Yes, oops. Cherry picked on top of 5.1 and resolved the few conflicts. After this is merged and merged up I'll need to do one last PR on 5 for the new pages or any other new content on 5 that isn't on 5.1