search

silverstripe / gha-ci

GitHub Actions Workflow - CI for Silverstripe modules
BSD 3-Clause "New" or "Revised" License
0 stars 11 forks source link

FIX Allow recipe-testing ^4 #109

Closed emteknetnz closed 8 months ago

emteknetnz commented 9 months ago

Issue https://github.com/silverstripe/.github/issues/199

GuySartorelli commented 9 months ago

Might as well just use * or >=2 at this point 😅

emteknetnz commented 8 months ago

Good idea though I don't think we use either of those anywhere else, the standard seems be to be just use a combination of ^ and || which is good in that it's better at preventing unexpected behavior so I think we should just keep using those

GuySartorelli commented 8 months ago

I don't think we use either of those anywhere else

That's not a reason to not do it here, if it makes sense to do it here. I think it makes sense to do the forward-compatible thing here.

That said, it doesn't matter enough for me to push this back. Just adding a note here that when we encounter a problem caused by this come CMS 7 time, we should update to use forward-compatible constraint at that time so we don't have to touch this every time we do a major release.