search

silverstripe / gha-ci

GitHub Actions Workflow - CI for Silverstripe modules
BSD 3-Clause "New" or "Revised" License
0 stars 11 forks source link

Broken builds from initial github actions CI config PRs #37

Closed GuySartorelli closed 2 years ago

GuySartorelli commented 2 years ago

We've added github actions CI but many of the builds are broken. We have decided to merge in CI config and treat the broken builds separately, so this issue is just to track fixing the broken builds.

Module Build Reason Effort
silverstripe/silverstripe-elemental-bannerblock build link failing behat test php 8 mysql 8 (was re-run) medium
silverstripe/silverstripe-externallinks build link broken behat test medium
silverstripe/silverstripe-ckan-registry build link behat failure medium
silverstripe/silverstripe-asset-admin build link behat 7.3 failed after re-run medium
silverstripe/silverstripe-subsites build link failing behat tests medium
silverstripe/silverstripe-graphql build link behat php 7.4 asset-admin 1.11.x-dev failed after 2x re-run (not same failure as asset-admin or recipe-cms) medium
silverstripe/silverstripe-login-forms build link sass-lint linting admin scss medium
silverstripe/cwp-agencyextensions build link failing yarn test medium
silverstripe/cwp-watea-theme build link can't build css medium
silverstripe/cwp-search build link prefer-lowest solr connection issue hard
silverstripe/silverstripe-contentreview build link wrong version of node - have tried both 6 and 10, pure guess module want 6 while admin uses 10 hard
symbiote/silverstripe-advancedworkflow build link git diff failing in js test hard
silverstripe/cow build link out of date requirements hard
silverstripe/recipe-solr-search build link unit test failure hard
silverstripe/silverstripe-behat-extension build link phplinting job only cannot install, likely conflict cow has with symfony and behat requirements hard
silverstripe/silverstripe-config codesniffer not added to composer.json as dev dependency easy
silverstripe/doorman codesniffer not added to composer.json as dev dependency easy
silverstripe/recipe-blog build link failing unit tests, probably phpunit 5 on silverstripe-comments possible needs to require a theme medium - do last
silverstripe/recipe-cms build link failing graphql unit test, same failure as on graphql 3.7 pr medium - do last
silverstripe/recipe-kitchen-sink build link various failures medium - do last
silverstripe/silverstripe-installer build link pdo utf8mb3 unit test failure + same failure as on graphql 3.7 pr medium - do last
silverstripe/recipe-content-blocks build link prefer-lowest a mess, 7.4 plus missing graphql FakeResolveInfo medium - do last
silverstripe/recipe-core build link prefer-lowest a mess, 7.4 plus various unit test failures medium - do last

Guy PRs

Steve PRs

GuySartorelli commented 2 years ago

I can't reproduce failures in the js builds such as these:

I was using nvm use so I'm definitely using the same version of node, and I copy/pasted the commands directly from gha-run-tests to make sure I was doing exactly what CI is doing. It passed fine locally, and didn't have those compiling messages after the git diff.

GuySartorelli commented 2 years ago

I'm unable to reproduce the behat failures in https://github.com/silverstripe/silverstripe-subsites/runs/7381806534?check_suite_focus=true I've tried having the exact same packages installed, and even though the failures in CI are happening on two different PHP versions and database versions, I've tried matching those as well.

GuySartorelli commented 2 years ago

Builds are green! Whoo!