Closed GuySartorelli closed 1 year ago
Requested changes made. I've run this through with a fork again just to be sure it's still doing what it's meant to at each branch of the conditions:
Note that for the above I spoofed the installer version, branch name, and module name as needed for the tests, but left the logic untouched. Note also that there are some small differences with the output of those examples than in the final PR - but all I have changed since running those is the echo statements so that won't affect anything vital, it still does the same things.
The approach is to check whether we have governance over the module, and if we don't, we skip checking the changes altogether.
We have governance over any module in the "silverstripe" github organisation, and over any supported branch of a supported module.
Examples
Ignore the CI failures in these examples - those are unrelated
GuySartorelli/silverstripe-admin
isn't supported at all.GITHUB_REF_NAME
fromGuySartorelli/silverstripe-admin
tosilverstripe/silverstripe-admin
), and to changeGITHUB_REF_NAME
to "3.9"GITHUB_REF_NAME
fromGuySartorelli/silverstripe-admin
tosilverstripe/silverstripe-admin
)Issue