silverstripe / gha-ci

GitHub Actions Workflow - CI for Silverstripe modules
BSD 3-Clause "New" or "Revised" License
0 stars 11 forks source link

dev/build, .env file creation, and other steps are performed when not needed #97

Closed GuySartorelli closed 9 months ago

GuySartorelli commented 9 months ago

Some of our repositories use this CI for convenience, but don't need a running Silverstripe CMS project.

When installer is not included, we shouldn't be setting up a database/etc.

At best this is unnecessary work, at worst it causes failures like https://github.com/creative-commoners/silverstripe-standards/actions/runs/7688362062/job/20949498104

PRs

emteknetnz commented 9 months ago

@GuySartorelli I left a comment on the merged PR to re-trigger some jobs to check things still work as expected. Once you've validated this close this issue

GuySartorelli commented 9 months ago

CI runs to validate this works post merge:

emteknetnz commented 9 months ago

@GuySartorelli Have merged latest PR, please re-run something to validate things still work correctly

GuySartorelli commented 9 months ago

Working as expected now