search

silverstripe / gha-generate-matrix

GitHub Action - CI matrix generator
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

Simplify steps in Generate Matrix workflow #18

Closed szepeviktor closed 2 years ago

szepeviktor commented 2 years ago

All improvements for good.

emteknetnz commented 2 years ago

Sorry, not going to merge this one, it's a bit risky just for bash script styling. We've standardized on double square brackets for bash conditionals, and the unindented multi line curl (we do this in many other places in other repos). Also ${{ github.base_ref && github.base_ref || github.ref_name }} is not bash, it's a github actions ternary.

szepeviktor commented 2 years ago

All right.