search

silverstripe / gha-generate-matrix

GitHub Action - CI matrix generator
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

FIX Add missing repo from hardcoded consts #37

Closed GuySartorelli closed 1 year ago

GuySartorelli commented 1 year ago

This repo was missing in https://github.com/silverstripe/gha-generate-matrix/pull/36 because it's not in the cowpat.

I've also added a commit here which will help avoid similar mistakes in the future by calling out if repositories are missing which were present in the previous release.

IMPORTANT

The person who merges this should tag a new patch version immediately afterward

Parent issue

michalkleiner commented 1 year ago

What if we ever wanted to remove a repo, we will get a warning until the last two sets have the same entries again? Not an urgent thing for now, may be never needed, just that we don't have a clear way of handling that.

GuySartorelli commented 1 year ago

What if we ever wanted to remove a repo, we will get a warning until the last two sets have the same entries again?

Running hardcoded.php is a manual process we do at beta-time. We currently manually copy and paste the output into the array in consts.php. So we'll only get the warning for the one release when it's manually run, and if we're intentionally removing the module from recipes then we just don't include the module we got warned about and therefore it won't warn again next time we run the script.