search

silverstripe / gha-generate-matrix

GitHub Action - CI matrix generator
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

NEW PHP 8.2 for CMS5 #39

Closed emteknetnz closed 1 year ago

emteknetnz commented 1 year ago

Issue https://github.com/silverstripe/silverstripe-framework/issues/10618

Once we're ready to test PHP 8.2 in all the CMS 5 builds we can branch to 1.6 and tag 1.6.0

We should do the tagging as part of this card - if we tag it before then then we're going to have lots of broken PHP 8.2 builds for CMS 5 which will only be annoying

GuySartorelli commented 1 year ago

IMO we should attach this PR to the card which you've said should trigger the tag - otherwise there's a risk of us tagging earlier than we want to. May as well just not merge until we're ready for it.

emteknetnz commented 1 year ago

Updated

GuySartorelli commented 1 year ago

Please resolve merge conflicts.

GuySartorelli commented 1 year ago

@emteknetnz ?? Still not done, not sure why this was assigned to me again?

emteknetnz commented 1 year ago

Updated

GuySartorelli commented 1 year ago

Sweet. Merged, I'll tag in a moment

GuySartorelli commented 1 year ago

Tagged as 1.7.0