search

silverstripe / gha-generate-matrix

GitHub Action - CI matrix generator
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

FIX Update getInstallerVersion #6

Closed emteknetnz closed 2 years ago

emteknetnz commented 2 years ago

Issue https://github.com/silverstripe/gha-ci/issues/11

Updating the logic in getInstallerVersion() so that the correct version is returned

Example failure

PHP Warning: Undefined array key "4.10/module-standards" in /home/runner/work/_actions/silverstripe/gha-generate-matrix/v1/job_creator.php on line 39

Also a slight refactor to allow adding unit tests for the yaml parsing

GuySartorelli commented 2 years ago

Can you please add some details to the PR description about what is actually being fixed or updated with this PR?

emteknetnz commented 2 years ago

Updated

emteknetnz commented 2 years ago

@GuySartorelli have made requested changes