silverstripe / gha-generate-matrix

GitHub Action - CI matrix generator
BSD 3-Clause "New" or "Revised" License
1 stars 5 forks source link

FIX Do not use recipe-plugin or vendor-plugin to work out cms major #82

Closed emteknetnz closed 4 months ago

emteknetnz commented 4 months ago

Issue https://github.com/silverstripe/.github/issues/199

recipe-plugin and vendor-plugin ^2 both work in CMS 5 + 6, so cannot be used to determine dynamically work the CMS major version of installer any more.

It caused 5.x-dev to be used instead of 6.x-dev on https://github.com/tractorcow-farm/silverstripe-fluent/actions/runs/8011520958/job/21884953244?pr=827

Note the bit in the release process where we update this is from involves copying .cow.pat.json and running php hardcoded.php - this is used to add to the INSTALLER_TO_REPO_MINOR_VERSIONS const. vendor-plugin and recipe-plugin will still appear for this in this and that's fine

However that isn't used to workout the CMS major version of installer to use in dynamic e.g. major dev branch with no minor branches, instead it's harcoded version out which version of installer to use for a specific module minor branch. This is different from the dynamic approach which is being disabled in this PR