Closed emteknetnz closed 1 year ago
@GuySartorelli Have implemented peer review feedback
Have tested updated code - works - https://github.com/emteknetnz/silverstripe-config/commits/2
There are still two unresolved conversations that you haven't responded to - please respond.
Replied
Issue https://github.com/silverstripeltd/product-issues/issues/753
Example of it in action - https://github.com/emteknetnz/silverstripe-config/commits/2
Here's an example of it failing on merge-conflict - https://github.com/emteknetnz/silverstripe-config/actions/runs/5526914815/jobs/10082502001
Here's an example of it failing where there's a difference in composer.json - https://github.com/emteknetnz/silverstripe-config/actions/runs/5527199168/jobs/10082717263