search

silverstripe / gha-merge-up

GitHub Action to merge-up supported branches in a repository
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Automated merge-ups don't work for developer-docs #11

Closed GuySartorelli closed 1 year ago

GuySartorelli commented 1 year ago

Automated merge-ups doesn't work for developer-docs, which is one of the places it's most useful.

Here's an example run: https://github.com/silverstripe/developer-docs/actions/runs/5866307877/job/15904858173

DEFAULT_BRANCH is 5 PHP Fatal error: Uncaught Exception: Could not work out what the default CMS major version this module uses in /home/runner/work/_actions/silverstripe/gha-merge-up/v1/funcs.php:56 Stack trace: #0 /home/runner/work/_actions/silverstripe/gha-merge-up/v1/branches.php(8): branches() #1 {main} thrown in /home/runner/work/_actions/silverstripe/gha-merge-up/v1/funcs.php on line 56

We should probably just add a special case for docs that just uses the branch name for the cms major version.

PRs

GuySartorelli commented 1 year ago

PR merged. This action now correctly finds the CMS version as expected: https://github.com/silverstripe/developer-docs/actions/runs/5866307877 There's a new failure on that run but it seems like it's more likely either a one-off problem or a systemic problem rather than a problem specific to this module so I'll close this card now.