silverstripe / github-actions-ci-cd

2 stars 2 forks source link

Migrate emteknetnz gha actions #36

Closed emteknetnz closed 2 years ago

emteknetnz commented 2 years ago

Create new repos on silverstripe account with emtpy readme only, then fork repos to emteknetnz, and create PRs with copy pasted contents from gha versions so they can all be peer reviewed

I'm thinking we should retain the gha- prefix instead of the github-actions- prefix, and also split the exsiting 'workflow_call' style github-actions-ci-ci repo to a pair of actions to be consistent:

ACs

PRs

The following will be handled with https://github.com/silverstripe/gha-ci/issues/4:

GuySartorelli commented 2 years ago

@emteknetnz Can you please add a meaningful description to each of the gha repositories? It will make it a lot easier to know at a glance what each repo is for.

emteknetnz commented 2 years ago

Descriptions are in the readme.md of each pull-request

GuySartorelli commented 2 years ago

6 months down the track, nobody will want to open each repo to remember, for example, the distinction between gha-auto-tag and gha-tag-release or what the purpose of gha-pull-request is. It's good practice to have a meaningful description for repositories.

emteknetnz commented 2 years ago

Oh, are you referring to text field in the actual github repo i.e.

image ?

GuySartorelli commented 2 years ago

Yes, that's the one. Sorry, I should have been more explicit.

emteknetnz commented 2 years ago

Have added descriptions on the silverstripe account repos

GuySartorelli commented 2 years ago

@emteknetnz PRs merged. I think the next step is for you to create a 1 branch for each repo and create a PR that swaps from using @main to @v1