search

silverstripe / recipe-ccl

A recipe to integrate a Silverstripe CMS project with the underlying infrastructure of Silverstripe Cloud Platform CCL.
BSD 3-Clause "New" or "Revised" License
1 stars 3 forks source link

DEP Use carets instead of dev requirements and use phpunit 9 #3

Closed emteknetnz closed 2 years ago

emteknetnz commented 3 years ago

Issue https://github.com/silverstripeltd/product-issues/issues/497

Now that CWP won't be getting regular releases via cow, it probably makes sense to change this to carets to support adhoc releases

emteknetnz commented 3 years ago

^ broken travis test is phpunit9 related - fix is to tag 2.9.0 (new minor) of cwp-core - https://github.com/silverstripe/cwp-core/pull/101/files

@maxime-rainville this might be a bit weird, particularly as that requires framework ^4.10 which is unreleased - may make sense to just merge this with broken unit test?

maxime-rainville commented 3 years ago

@emteknetnz Do you want to do a new cwp-core tag. It seemed to work for the other module?

emteknetnz commented 3 years ago

@maxime-rainville tagged cwp-core 2.9.0 and rerunning the build on this

emteknetnz commented 3 years ago

Unit test requires silverstripe/admin 4.10/4.x-dev due to phpunit 9

Requirement for admin would need to be updated in to ^4.10 in https://github.com/silverstripe/cwp-core/blob/2/composer.json

However I tagged cwp-core 2.9.0 just the other day, probably a little excessive tagged 2.10 days later - might make sense to just remove the tag and retag - though this would require us deleting the tag in packagist as well which I don't have enough permissions to do https://packagist.org/packages/cwp/cwp-core#2.9.0

Other option is just tag 2.9.1, though I'm not sure if that's semver correct

maxime-rainville commented 3 years ago

I'm fine tagging 2.9.1. As a general rule, we should never undo a tag.

emteknetnz commented 3 years ago

Cool - PR https://github.com/silverstripe/cwp-core/pull/104