search

silverstripe / recipe-cms

Silverstripe recipe for fully featured page and asset content editing
BSD 3-Clause "New" or "Revised" License
20 stars 14 forks source link

DEP Require 3.x-dev instead of 3.5.x-dev for graphql #46

Closed emteknetnz closed 3 years ago

emteknetnz commented 3 years ago

Issue https://github.com/silverstripe/silverstripe-versioned/issues/332

3.5.x-dev || 4.x-dev is an odd-requirement that does not match others modules which have 3.x-dev || 4.x-dev e.g. https://github.com/silverstripe/silverstripe-versioned/blob/1/composer.json#L28

This causes a mismatch which has lead to recipe-cms being uninstallable with grahpql on php 7.1. Instead it trys to install it with graphql 4, which is not compatibile with php7.1 https://travis-ci.com/github/silverstripe/silverstripe-versioned/jobs/505773173

emteknetnz commented 3 years ago

Closed in favour of updating other modules to graphql 3.5.x-dev

https://github.com/silverstripeltd/product-issues/issues/431