silverstripe / recipe-cms

Silverstripe recipe for fully featured page and asset content editing
BSD 3-Clause "New" or "Revised" License
20 stars 14 forks source link

Add silverstripe/session-manager #47

Closed brynwhyman closed 3 years ago

brynwhyman commented 3 years ago

On enhancing the session-manager module, it's something that's likely to provide broad benefit and is almost a baseline feature for any CMS or tool where software users manage their profile.

When considering the path of least resistance on making this module available to projects, this recipe was considered the best place to add it.

Other options that were considered were, from widest distribution to least distribution: a) require as part of silverstripe/admin (aka "add it to core") b) require as part of silverstripe/recipe-cms (not recipe-core, that does not include admin) c) require as part of silverstripe/installer d) require as part of silverstripe/silverstripe-security-extensions (not even sure what uses this?) e) manually add to project (this is always an option)

Questions of stability

The silverstripe/session-manager module has been out in the wild for some time with a 0.x tag while early testing and feedback is sought.

We've been managing a bit of testing and user feedback internally, which will help us confirm confidence in tagging the module as stable and including it in this recipe.

Implementation tasks

Tasks required as part of this issue could be:

PRs - update unit tests to use logInAs()

PRs - follow up

PR - update recipe-cms

PRs - Docs

PRs - Sink (remember to merge-up)

SwiftMailer v6 not allowing spaces at start or end of email addresses

TODO

emteknetnz commented 3 years ago

https://travis-ci.com/github/silverstripe/silverstripe-installer/jobs/532576643 https://travis-ci.com/github/silverstripe/cwp-recipe-kitchen-sink/jobs/532563593

https://travis-ci.com/github/silverstripe/cwp-recipe-kitchen-sink/jobs/532563590

https://travis-ci.com/github/silverstripe/cwp-recipe-kitchen-sink/jobs/532563602