Additional CMS Pattern Library improvements. - Githubissues

silverstripe / recipe-cms

Silverstripe recipe for fully featured page and asset content editing

BSD 3-Clause "New" or "Revised" License

20 stars 14 forks source link

Additional CMS Pattern Library improvements. #75

Closed sabina-talipova closed 1 year ago

sabina-talipova commented 1 year ago

Description

The following improvements need to be made:

[x] Replace 4 space indent with a 2 space. ESlint doesn't help.
[ ] Introduce a new library @storybook/addon-docs to present documentation to the components.
[x] Fix / investigate the reasons for some small warnings that happens time to time in browser console when storybook is running.

AC's

[x] Component stories have 2 space indent everywhere in the code.
[ ] @storybook/addon-docs is implemented and all stories that have pre-existing readme doc are using it.
[x] If possible there are not any warnings in the console when storybook is running.

PR's

emteknetnz commented 1 year ago

@sabina-talipova I've approved all the PRs - you can self-merge them once https://github.com/silverstripe/silverstripe-versioned-admin/pull/296 has been merged - we'd want to merge that one first so that builds go green after merging