silverstripe / silverstripe-admin

Silverstripe Admin Component
BSD 3-Clause "New" or "Revised" License
25 stars 91 forks source link

Security warning is gone #1703

Closed ssmarco closed 1 month ago

ssmarco commented 3 months ago

Module version(s) affected

5.0.0

Description

The security warning that says, "Caution: Removing members from this list will remove them from all groups and the database". Is this something that be added back? See screenshot below.

image

How to reproduce

To reproduce, please login to the CMS and go to the Security section. From there, no warning is shown on the top of the list of users.

Possible Solution

No response

Additional Context

No response

Validations

GuySartorelli commented 3 months ago

Looks like an oversight from when SecurityAdmin was converted to be a ModelAdmin. If you'd like to make a PR to add it back I'd be happy to review it, but the CMS Squad won't be prioritising this.

GuySartorelli commented 1 month ago

As there hasn't been a PR raised for this, I'm going to close it. I think the nature of how deleting records in the CMS works is well established by this point, so we don't really need to warn people that deleting a user will delete the user.